Add uplink_sequence() method to IntegrationTestAPI#281
Merged
thomas-bc merged 1 commit intonasa:develfrom Feb 5, 2026
Merged
Conversation
thomas-bc
approved these changes
Feb 2, 2026
Collaborator
thomas-bc
left a comment
thomas-bc
left a comment
There was a problem hiding this comment.
This is great, thanks a lot for contributing back. Was this tested end-to-end locally? It'd be good if we could get some testing in there for CI...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Hey team, This PR adds
uplink_sequence()anduplink_sequence_and_await_completion()helper methods to theIntegrationTestAPIclass.uplink_sequence()compiles text sequence files into bins and then passes them to theuplink_file()method.Rationale
I'm writing tests that verify sequences are cancelled under certain conditions. In our repo I have access to a
.seqtext file and I think this kind of helper feels more natural living upstream.Testing/Review Recommendations
I have run tests using
uplink_sequence_and_await_completion()and verified that they are uplinking and eventing successfully.Future Work
I didn't feel like there was a consistent method for catching and reraising errors in this class. Happy to take feed back on the implementation.